Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maintained igor2 instead of unmaintained igor #128

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

AurelienJaquier
Copy link
Collaborator

No description provided.

@AurelienJaquier AurelienJaquier self-assigned this Feb 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #128 (529ae3f) into master (431fd34) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   65.25%   65.25%           
=======================================
  Files          31       31           
  Lines        2058     2058           
=======================================
  Hits         1343     1343           
  Misses        715      715           
Impacted Files Coverage Δ
bluepyefe/igorpy/__init__.py 91.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AurelienJaquier
Copy link
Collaborator Author

There is a fork of igor that is maintained and includes our changes: AFM-analysis/igor2#4
However, it has a hard requirement for python 3.8. Is it ok if we start using it and also require python 3.8 for BluePyEfe @wvangeit ? Latest numpy also use at least py38 and py37 will reach end of life in June.

README.md Outdated Show resolved Hide resolved
@AurelienJaquier AurelienJaquier merged commit ae46d26 into BlueBrain:master Feb 15, 2023
@AurelienJaquier AurelienJaquier deleted the igor2 branch February 15, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants