-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sonata_tech.rst #5
Open
vignan21
wants to merge
1
commit into
BlueBrain:master
Choose a base branch
from
vignan21:vignan21-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better wording…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "MOD" is too general. Would suggest "Cholinergic." It will prevent confusion down the line once additional neuromodulatory types are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vignan21 can you update accordingly ?
@MWolfR @romani79 no other comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes made by @matz-e seem reasonable. @dkeller9 - we are trying to define a third class of neuron types which are neuromodulatory. So under "MOD", all types of neuromodulatory neurons will fall. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vignan21 I like your suggest. The synapse class remains MOD, but then we can have different synapse class for each neuromodulator. We can start with M1 for Acetylcholine. I think this is enough for now. We can always append new type/neuromodulator depending on our needs. Listing "all" the neuromodulators and their combinations may be too much. Let's start simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first reaction is that this seems redundant if we assume that for a given synapses the presynaptic terminal releases the neurotransmitter compatible with the postsynaptic receptors. This is a fair assumption and we avoid useless complications.
I would ask the other scientists if I am missing obvious exceptions for which we should specify presynaptic neurotransmitters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends a bit for which simulator aspects we are gonna use this. If e.g. this relates to which MOD files to load etc., it might not be redundant information. Let's say we have a presynaptic GABA release mechanism, but it gets picked up by GABA-A and GABA-B receptors, in that case it might be useful to separate neurotransmitter (or release mechanism?) from receptor. Of course, we're talking about the future, I'm not sure we have a use case right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, I created a bit of mess here. The topic is about node file, while I was discussion more in terms of edge file. During the meeting, we commented that the column on Exc/Inh in the node file may be redundant if we have the postsynapse receptor information in the edge file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wvangeit the redundancy is at the level of neurotransmitter release, but both receptor and model files are essential information as you pointed out. The proposal we had in the meeting is to store the information on receptor in the edge file, and the information on which mod file to use outside the edge file (e.g. recipe, Neurodamus).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I like this proposal. The format is a "circuit model definition", so which mod file to load should be defined in the circuit as we do with morphologies, or with the e-model to load. That is the information that is needed to the simulator.