Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make interface optional on method calls #390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

izak
Copy link

@izak izak commented Feb 12, 2025

The dbus spec allows the interface to be optional on method calls. In that case, allow the message to match on any method with a matching name and signature.

#315

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (c713bf3) to head (1e61584).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   84.00%   83.91%   -0.09%     
==========================================
  Files          28       28              
  Lines        3388     3388              
  Branches      607      607              
==========================================
- Hits         2846     2843       -3     
- Misses        334      338       +4     
+ Partials      208      207       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The dbus spec allows the interface to be optional on
method calls. In that case, allow the message to match
on any method with a matching name and signature.

Bluetooth-Devices#315
@izak izak force-pushed the fix-optional-interface branch from 6f26e87 to 1e61584 Compare February 12, 2025 08:41
Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #390 will not alter performance

Comparing izak:fix-optional-interface (1e61584) with main (c713bf3)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco changed the title make interface optional on method calls feat: make interface optional on method calls Feb 12, 2025
@bdraco
Copy link
Member

bdraco commented Feb 12, 2025

Would you please add a test case for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants