Fixed failing book view test

Also ensured setting system localcache is cleared correctly
BookStackApp · Dec 30, 2017 · 96b8c40 · Abijeet · Dec 30, 2017 · 96b8c40
1 parent 359b1b4
commit 96b8c40
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/Services/SettingService.php b/app/Services/SettingService.php
@@ -98,6 +98,9 @@ protected function clearFromCache($key)
     {
         $cacheKey = $this->cachePrefix . $key;
         $this->cache->forget($cacheKey);
+        if (isset($this->localCache[$key])) {
+            unset($this->localCache[$key]);
+        }
     }
 
     /**

diff --git a/tests/Entity/EntityTest.php b/tests/Entity/EntityTest.php
@@ -90,14 +90,14 @@ public function test_toggle_book_view()
         $this->actingAs($editor)
             ->visit('/books')
             ->pageHasElement('.featured-image-container')
-            ->submitForm('Toggle Book View')
+            ->submitForm('List View')
             // Check redirection.
             ->seePageIs('/books')
             ->pageNotHasElement('.featured-image-container');
 
         $this->actingAs($editor)
             ->visit('/books')
-            ->submitForm('Toggle Book View')
+            ->submitForm('Grid View')
             ->seePageIs('/books')
             ->pageHasElement('.featured-image-container');