Update to latest plyodine

BradleyMarie · Jan 14, 2025 · 4d964f3 · 4d964f3
1 parent a3104e4
commit 4d964f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -25,5 +25,5 @@ bazel_dep(name = "plyodine")
 git_override(
     module_name = "plyodine",
     remote = "https://github.com/bradleymarie/plyodine.git",
-    commit = "7323685df340b61df0e8a6d4427ae31d2eb2273b",
+    commit = "d4d4912a97201126eb8870fa5a645e685f5e9581",
 )
diff --git a/frontends/pbrt/shapes/plymesh.cc b/frontends/pbrt/shapes/plymesh.cc
@@ -23,8 +23,6 @@ class TriangleMeshReader final
   TriangleMeshReader(const Matrix& model_to_world)
       : model_to_world_(model_to_world) {}
 
-  void Start() override {}
-
   void AddVertex(const std::array<geometric, 3>& position,
                  const std::array<geometric, 3>* maybe_normal,
                  const std::array<geometric, 2>* maybe_uv) override {
@@ -54,7 +52,7 @@ class TriangleMeshReader final
     }
   }
 
-  void AddFace(const std::array<uint32_t, 3>& face) override {
+  void AddTriangle(const std::array<uint32_t, 3>& face) override {
     faces.emplace_back(face[0], face[1], face[2]);
   }
 
@@ -117,10 +115,9 @@ PlyMeshBuilder::Build(
   }
 
   TriangleMeshReader reader(model_to_world);
-  auto result = reader.ReadFrom(file_stream);
-  if (!result) {
+  if (std::error_code error = reader.ReadFrom(file_stream); error) {
     std::cerr << "ERROR: PLY file parsing failed with message: "
-              << result.error() << std::endl;
+              << error.message() << std::endl;
     exit(EXIT_FAILURE);
   }