-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmuldrew/smart calculate charging #324
Dmuldrew/smart calculate charging #324
Conversation
``` mermaid | ||
graph TD | ||
A[Vehicle Demand Interface Function] -->|choose vehicle type, vehicle range, model year, charging strategy| B(Load Data) | ||
I --> |evaluate whether charging is available| C{calculate charging over \n given trip window} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are trying to roll into a new line by \n
here but I don't see this deployed properly in the preview. Not sure what is the right way to do so in mermaid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
daily_vmt_total, | ||
kwh, | ||
bev_vmt, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still adding doc strings to this function and might remove a couple parameters
prereise/gather/demanddata/transportation_electrification/smart_charging.py
Show resolved
Hide resolved
Last commit makes implements the following changes: The current ratio of total yearly BEV demand for immediate and smart charging is: |
bcc38ef
to
a80e79e
Compare
31ead30
to
24cde85
Compare
20d6e17
to
3404d1c
Compare
Pull Request doc
Purpose
Moves the daily smart charging optimization into a function similar to the immediate charging. This will allow both strategies to share a common loop over days of year.
Adds a mermaid architecture diagram a goal for the refactor.
What the code is doing
calculate_daily_smart_charging_trips
Testing
Automated testing
Time estimate
~15min