Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqf: Add lint (S25) for count array comparisons #859

Open
wants to merge 1 commit into
base: inspector
Choose a base branch
from

Conversation

PabstMirror
Copy link
Collaborator

e.g.

help[L-S25]: count array comparison
   ┌─ addons/common/functions/fnc_loadPersonLocal.sqf:33:35
   │
33 │         if (count _preferredSeats > 0) then {
   │                                   ^
   │
   = note: use `isNotEqualTo []`

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 82.40000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 68.7%. Comparing base (68d8a72) to head (9b25b91).

Files with missing lines Patch % Lines
libs/sqf/src/analyze/lints/s25_count_array_comp.rs 78.4% 20 Missing ⚠️
libs/sqf/src/analyze/inspector/commands.rs 92.3% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/analyze/inspector/mod.rs 93.6% <100.0%> (+<0.1%) ⬆️
...s/sqf/src/analyze/lints/s21_invalid_comparisons.rs 75.0% <100.0%> (ø)
libs/sqf/src/analyze/inspector/commands.rs 80.6% <92.3%> (+0.9%) ⬆️
libs/sqf/src/analyze/lints/s25_count_array_comp.rs 78.4% <78.4%> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant