Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting which image to use #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emlowe
Copy link

@emlowe emlowe commented Jan 9, 2025

The unsplash API supports the following (https://unsplash.com/documentation#example-image-use):

  • full returns the photo in jpg format with its maximum dimensions. For performance purposes, we don’t recommend using this as the photos will load slowly for your users.
  • regular returns the photo in jpg format with a width of 1080 pixels.
  • small returns the photo in jpg format with a width of 400 pixels.
  • thumb returns the photo in jpg format with a width of 200 pixels.
  • raw returns a base image URL with just the photo path and the ixid parameter for your API application. Use this to easily add additional image parameters to construct your own image URL.

This module currently always uses the full photo. On a lower-power device or a smaller screen, this is less optimal and probably results in using more RAM and network bandwidth than necessary.

This PR adds in a new config item unsplashSize (not a great name, but I couldn't think of anything else) which allows you to specify one of the above settings. The default remains full

I'll note that the current size config item appears to be entirely unused, so possibly we could just repurpose that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant