Upgrade deps #605
Upgrade deps #605
Conversation
…o 4.7.1, checkstyle to 10.3.2, jlink to 2.25.0, jackson to 2.13.3, and jupiter to 5.9.0.
|
Love it. Would you mind throwing one more in? Update javafx to version 18 in build.gradle: // ### JavaFX plugin settings This is actually a =problem for me because the GUI crashes on M1 :/ Fixed in version 18. |
…iscellaneous clean-up in `DominionCvrReader`.
|
Updated! |
| // Keep the below file updated along with subsequent versions of Checkstyle (make sure to choose | ||
| // the tag matching the toolVersion above): | ||
| // https://github.com/checkstyle/checkstyle/blob/checkstyle-10.2/src/main/resources/google_checks.xml | ||
| // https://github.com/checkstyle/checkstyle/blob/checkstyle-10.3.2/src/main/resources/google_checks.xml | ||
| // NOTE: It may also be necessary to change "${org.checkstyle.google.suppressionfilter.config}" |
There was a problem hiding this comment.
I don't understand this note.
EDIT: ah, I see that this changed in the file itself. Can you clarify this comment to:
- cite something
- indicate that the edit takes place in that file?
Also, was that file updated by just downloading a new one? It might be good to write down a curl command here; you could even write curl ... | sed s|org.checkstyle...|\${config_log}/...| to automate this away entirely.
There was a problem hiding this comment.
Added more context per your request. Yeah, I just copy and paste it from GH usually, and I like the idea of automating it with a script like that except the address would need to be changed each time to the match most recent version posted to the Maven repo, and sed is a no-go in my Windows environment. :/
There was a problem hiding this comment.
Ack, sorry, missed this PR with this change. Will include it in my next.
| @@ -1,5 +1,16 @@ | |||
| # | |||
| # RCTab | |||
There was a problem hiding this comment.
isn't there a gradle command that generates these files? if yes, it may not make sense to put these license headers there.
There was a problem hiding this comment.
Good catch, this definitely shouldn't be appearing in here. I'll fix the auto-copyright rules and clean these up.
Upgrades Gradle to 7.5.1, spotbugs-gradle-plugin to 5.0.9, spotbugs to 4.7.1, checkstyle to 10.3.2, jlink to 2.25.0, jackson to 2.13.3, jupiter to 5.9.0, and javafx to 18. Also fixes
uncheckedJava compiler warning and issue where copyright was being inserted in non-source files.NOTE:
org.openjfx.javafxpluginto 0.0.13, but was blocked by this issuegoogle_checks.xml