Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @open-wc/testing from 3.2.2 to 4.0.0 #256

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps @open-wc/testing from 3.2.2 to 4.0.0.

Release notes

Sourced from @​open-wc/testing's releases.

@​open-wc/testing@​4.0.0

Major Changes

  • Updated dependencies [c69af75f]
    • @​open-wc/testing-helpers@​3.0.0

If you're using a fixture like so with scoped elements:

await fixture(html`...`, { scopedElements: ... });

You're gonna have to load the @​webcomponents/scoped-custom-element-registry polyfill yourself first.

Changelog

Sourced from @​open-wc/testing's changelog.

4.0.0

Major Changes

  • Updated dependencies [c69af75f]
    • @​open-wc/testing-helpers@​3.0.0

If you're using a fixture like so with scoped elements:

await fixture(html`...`, { scopedElements: ... });

You're gonna have to load the @​webcomponents/scoped-custom-element-registry polyfill yourself first.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 13, 2023 10:12
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 13, 2023
@dlockhart
Copy link
Member

@svanherk I think we determined all consumers were at least on Node 18 and that we're good to make this change?

@svanherk
Copy link
Contributor

svanherk commented Nov 13, 2023

@svanherk I think we determined all consumers were at least on Node 18 and that we're good to make this change?

Yes, but there's a small quotes issue and this is the more complete change: #253

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/open-wc/testing-4.0.0 branch from e820f82 to f7bcde5 Compare November 14, 2023 18:23
@svanherk
Copy link
Contributor

@dependabot rebase

Bumps [@open-wc/testing](https://github.com/open-wc/open-wc/tree/HEAD/packages/testing) from 3.2.2 to 4.0.0.
- [Release notes](https://github.com/open-wc/open-wc/releases)
- [Changelog](https://github.com/open-wc/open-wc/blob/master/packages/testing/CHANGELOG.md)
- [Commits](https://github.com/open-wc/open-wc/commits/@open-wc/[email protected]/packages/testing)

---
updated-dependencies:
- dependency-name: "@open-wc/testing"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/open-wc/testing-4.0.0 branch from f7bcde5 to 0a985bd Compare November 14, 2023 18:26
@svanherk
Copy link
Contributor

@svanherk I think we determined all consumers were at least on Node 18 and that we're good to make this change?

Yes, but there's an issue a small quotes issue and this is the more complete change: #253

Ugh, I finally see what you mean lol - I forgot to update to @open-wc/testing v4 in that PR 🤦. Updated everything else

Copy link
Contributor

@svanherk svanherk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine in core: BrightspaceUI/core#4247

@svanherk svanherk merged commit c6ea549 into main Nov 14, 2023
2 checks passed
@svanherk svanherk deleted the dependabot/npm_and_yarn/open-wc/testing-4.0.0 branch November 14, 2023 18:58
@ghost
Copy link

ghost commented Nov 14, 2023

🎉 This PR is included in version 1.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants