Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle text input in react native generator #1435

Merged
merged 10 commits into from
May 17, 2024
Merged

fix: handle text input in react native generator #1435

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
369c8aa
fix: handle text input in react native generator
May 8, 2024
db376d3
Merge branch 'main' into main
Othman2001 May 9, 2024
8769081
test: update snapshots
May 10, 2024
bb2d8e4
Merge branch 'main' of github.com:Othman2001/mitosis
May 10, 2024
ec7cd0e
refactor: check on node name instead of bindings in react native gene…
May 15, 2024
7834477
lint: run formatting on changed files
May 16, 2024
629098a
refactor: restore node.name assigment line in react native genertor
May 16, 2024
9b3341e
Merge branch 'main' into main
Othman2001 May 16, 2024
226d7bc
test: update snapshots for marko.test.ts and solid.test.ts
May 16, 2024
9315836
Merge branch 'main' of github.com:Othman2001/mitosis
May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/generators/react-native/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,15 @@ const PROCESS_REACT_NATIVE_PLUGIN: Plugin = () => ({
if (node.bindings.onClick) {
node.name = 'Pressable';
}
if(node.bindings.onChange){
node.name = 'TextInput'
}
samijaber marked this conversation as resolved.
Show resolved Hide resolved
} else if (
node.properties._text?.trim().length ||
node.bindings._text?.code?.trim()?.length
) {
node.name = 'Text';
}

if (node.properties.class) {
delete node.properties.class;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/generators/react/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ const getDefaultImport = (json: MitosisComponent, options: ToReactOptions): stri
if (type === 'native') {
return `
import * as React from 'react';
import { FlatList, ScrollView, View, StyleSheet, Image, Text, Pressable } from 'react-native';
import { FlatList, ScrollView, View, StyleSheet, Image, Text, Pressable, TextInput } from 'react-native';
`;
}
if (type === 'taro') {
Expand Down