Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Random failures with Jest CI #400

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jun 7, 2024

Overview

This PR should fix a randomized test failure caused by React Hook Form. See the action run 9411823501 or 9418434115.

I can't replicate this issue locally, but I did re-run the Jest job against this PR 5 times without issues:

Change Details (Specifics)

  • Wrap a test case in act and disable linting against it

Related Ticket(s)

N/A

@amattu2 amattu2 marked this pull request as ready for review June 7, 2024 14:28
@amattu2 amattu2 requested a review from Alejandro-Vega June 7, 2024 14:28
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega added the Not Run This PR was not tested locally label Jun 7, 2024
@Alejandro-Vega Alejandro-Vega merged commit e6025da into 3.0.0 Jun 7, 2024
11 checks passed
@Alejandro-Vega Alejandro-Vega deleted the fix-data-upload-test branch June 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants