Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-1234 Add CTDC Data Common #411

Merged
merged 2 commits into from
Jul 2, 2024
Merged

CRDCDH-1234 Add CTDC Data Common #411

merged 2 commits into from
Jul 2, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jun 27, 2024 •
edited
Loading

Overview

This PR adds CTDC to the Data Commons list and also model navigator.

Note

See the PR here for adding CTDC to our models repo.

Change Details (Specifics)

  • Add generic data commons logo (previously designed)
  • Add model navigator config for CTDC
  • Add a basic test case to ensure the DataCommons object is always sorted alphabetically
    • This variable is used in a few different places, so it was easiest just to assert that the object itself was sorted

Related Ticket(s)

CRDCDH-1234
CRDCDH-1235

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jun 27, 2024
@amattu2 amattu2 added this to the 3.0.0 (PMVP-M1) milestone Jun 27, 2024
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jul 2, 2024
@amattu2 amattu2 requested review from Alejandro-Vega and ty-esi July 2, 2024 17:08
@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9765138312

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.634%
Totals Coverage Status
Change from base Build 9749197772: 0.0%
Covered Lines: 1982
Relevant Lines: 4811
💛 - Coveralls

Alejandro-Vega
Alejandro-Vega approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! LGTM!

@Alejandro-Vega Alejandro-Vega merged commit fd568df into 3.0.0 Jul 2, 2024
6 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1234-1235 branch July 2, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

@ty-esi ty-esi Awaiting requested review from ty-esi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0 (PMVP-M1)
Development

Successfully merging this pull request may close these issues.
3 participants
@amattu2 @coveralls @Alejandro-Vega