Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new search index and function on release #206

Open
wants to merge 3 commits into
base: 3.2.0
Choose a base branch
from
Open

Add new search index and function on release #206

wants to merge 3 commits into from
+142 −30

Conversation

vshand11
Copy link
Collaborator

@vshand11 vshand11 commented Dec 2, 2024

  1. Add new search index (studyID_entiryType_nodeID) in release collection when validator service started.
  2. Add new search function, search_release_node_by_study, in common.mongo_dao.py.
  3. updated search_node_by_study to call search_release_node_by_study first, if not found, then search dataRecords.

@vshand11 vshand11 requested a review from n2iw December 2, 2024 20:23
n2iw
n2iw requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@n2iw n2iw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase/redo this target 3.2.0 branch, thanks!

@vshand11 vshand11 changed the base branch from 3.1.0 to 3.2.0 December 10, 2024 16:04
@vshand11 vshand11 changed the title Fixed Add new search index and function on release Dec 10, 2024
@vshand11
Copy link
Collaborator Author

Manually merged 3.1.0 changes to the branch and passed testing.

@n2iw n2iw changed the base branch from 3.2.0 to master December 19, 2024 17:18
@n2iw n2iw changed the base branch from master to 3.2.0 December 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2iw n2iw n2iw requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshand11 @n2iw