Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't check tempdir writeability #118

Merged
merged 2 commits into from
Oct 2, 2024
+2 −2
Merged

fix: don't check tempdir writeability #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59dfaae
fix: don't check tempdir writeability
kelly-sovacool Oct 1, 2024
3dc75dc
chore: update CHANGELOG.md
kelly-sovacool Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## CHARLIE development version

- Fix bug where CHARLIE was falsely throwing a file permissions error for tempdir values containing bash variables. (#118, @kelly-sovacool)

## CHARLIE 0.11.0

- Major updates to convert CHARLIE from a biowulf-specific to a platform-agnostic pipeline (#102, @kelly-sovacool):
Expand Down
2 changes: 0 additions & 2 deletions workflow/rules/init.smk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ def _convert_to_int(variable):
# resource absolute path
WORKDIR = config["workdir"]
TEMPDIR = config["tempdir"]
if not os.access(TEMPDIR, os.W_OK):
raise PermissionError(f"TEMPDIR {TEMPDIR} cannot be written to.\n\tHint: does the path exist and do you have write permissions?")

SCRIPTS_DIR = config["scriptsdir"]
RESOURCES_DIR = config["resourcesdir"]
Expand Down