ocr_bitmap can run out of buffer memory copying the "last font tag"

docs/CHANGES.TXT

@@ -37,6 +37,7 @@
 - Improvement: Ignore MXF Caption Essence Container version byte to enhance SRT subtitle extraction compatibility
 - New: Add tesseract page segmentation modes control with `--psm` flag
 - Fix: Resolve compile-time error about implicit declarations (#1646)
+- Fix: fatal out of memory error extracting from a VOB PS
 
 0.94 (2021-12-14)
 -----------------

src/lib_ccx/asf_functions.c

@@ -561,7 +561,7 @@ int asf_get_more_data(struct lib_ccx_ctx *ctx, struct demuxer_data **ppdata)
 		dbg_print(CCX_DMT_PARSE, "Number of data packets: %ld\n", (long)asf_data_container.TotalDataPackets);
 
 		reentry = 0; // Make sure we read the Data Packet Headers
-	}		     // End of if (firstcall)
+	} // End of if (firstcall)
 	firstcall = 0;
 
 	// Start loop over Data Packets

src/lib_ccx/ccx_decoders_common.c

@@ -219,7 +219,7 @@ int do_cb(struct lib_cc_decode *ctx, unsigned char *cc_block, struct cc_subtitle
 			default:
 				fatal(CCX_COMMON_EXIT_BUG_BUG, "In do_cb: Impossible value for cc_type, Please file a bug report on GitHub.\n");
 		} // switch (cc_type)
-	}	  // cc_valid
+	} // cc_valid
 	else
 	{
 		dbg_print(CCX_DMT_CBRAW, "    ..   ..   ..\n");

src/lib_ccx/ccx_encoders_spupng.c

@@ -704,7 +704,11 @@ uint32_t *utf8_to_utf32(char *src)
 }
 
 // Convert big-endian and little-endian
-#define BigtoLittle32(A) ((((uint32_t)(A)&0xff000000) >> 24) | (((uint32_t)(A)&0x00ff0000) >> 8) | (((uint32_t)(A)&0x0000ff00) << 8) | (((uint32_t)(A)&0x000000ff) << 24))
+#define BigtoLittle32(A) (                 \
+    (((uint32_t)(A) & 0xff000000) >> 24) | \
+    (((uint32_t)(A) & 0x00ff0000) >> 8) |  \
+    (((uint32_t)(A) & 0x0000ff00) << 8) |  \
+    (((uint32_t)(A) & 0x000000ff) << 24))
 
 // Generate PNG file from an UTF-8 string (str)
 // PNG file will be stored at output

src/lib_ccx/dvb_subtitle_decoder.c

@@ -39,20 +39,20 @@
 
 #define YUV_TO_RGB1_CCIR(cb1, cr1)                                                               \
 	{                                                                                        \
-		cb = (cb1)-128;                                                                  \
-		cr = (cr1)-128;                                                                  \
+		cb = (cb1) - 128;                                                                \
+		cr = (cr1) - 128;                                                                \
 		r_add = FIX(1.40200 * 255.0 / 224.0) * cr + ONE_HALF;                            \
 		g_add = -FIX(0.34414 * 255.0 / 224.0) * cb - FIX(0.71414 * 255.0 / 224.0) * cr + \
 			ONE_HALF;                                                                \
 		b_add = FIX(1.77200 * 255.0 / 224.0) * cb + ONE_HALF;                            \
 	}
 
-#define YUV_TO_RGB2_CCIR(r, g, b, y1)               \
-	{                                           \
-		y = ((y1)-16) * FIX(255.0 / 219.0); \
-		r = cm[(y + r_add) >> SCALEBITS];   \
-		g = cm[(y + g_add) >> SCALEBITS];   \
-		b = cm[(y + b_add) >> SCALEBITS];   \
+#define YUV_TO_RGB2_CCIR(r, g, b, y1)                 \
+	{                                             \
+		y = ((y1) - 16) * FIX(255.0 / 219.0); \
+		r = cm[(y + r_add) >> SCALEBITS];     \
+		g = cm[(y + g_add) >> SCALEBITS];     \
+		b = cm[(y + b_add) >> SCALEBITS];     \
 	}
 
 #define times4(x) x, x, x, x

src/lib_ccx/dvd_subtitle_decoder.c

@@ -384,7 +384,7 @@ int process_spu(struct lib_cc_decode *dec_ctx, unsigned char *buff, int length,
 
 	if (ctx->append == 1)
 	{
-		memcpy(ctx->buffer + ctx->len, buff, length);
+		memmove(ctx->buffer + ctx->len, buff, length);
 		ctx->len += length;
 		ctx->append = 0;
 	}

src/lib_ccx/general_loop.c

@@ -993,7 +993,7 @@ int general_loop(struct lib_ccx_ctx *ctx)
 	enum ccx_stream_mode_enum stream_mode;
 	struct demuxer_data *datalist = NULL;
 	struct demuxer_data *data_node = NULL;
-	int (*get_more_data)(struct lib_ccx_ctx * c, struct demuxer_data * *d);
+	int (*get_more_data)(struct lib_ccx_ctx *c, struct demuxer_data **d);
 	int ret;
 	int caps = 0;
 

src/lib_ccx/hardsubx_decoder.c

@@ -552,7 +552,7 @@ void process_hardsubx_linear_frames_and_normal_subs(struct lib_hardsubx_ctx *har
 	enum ccx_stream_mode_enum stream_mode;
 	struct demuxer_data *datalist = NULL;
 	struct demuxer_data *data_node = NULL;
-	int (*get_more_data)(struct lib_ccx_ctx * c, struct demuxer_data * *d);
+	int (*get_more_data)(struct lib_ccx_ctx *c, struct demuxer_data **d);
 	int ret;
 	int caps = 0;
 

src/lib_ccx/ocr.c

@@ -620,6 +620,7 @@ char *ocr_bitmap(void *arg, png_color *palette, png_byte *alpha, unsigned char *
 					// realloc if memory allocated may be not enough
 					int length_needed = (new_text_out_iter - new_text_out) +
 							    (line_end - line_start) +
+							    (last_font_tag_end ? (last_font_tag_end - last_font_tag) : 0) +
 							    length_closing_font + 32;
 
 					if (length_needed > length)

src/rust/src/decoder/encoding.rs

@@ -1,16 +1,16 @@
-/// 256 BYTES IS ENOUGH FOR ALL THE SUPPORTED CHARACTERS IN
-/// EIA-708, SO INTERNALLY WE USE THIS TABLE (FOR CONVENIENCE)
-///
-/// 00-1F -> Characters that are in the G2 group in 20-3F,
-///          except for 06, which is used for the closed captions
-///          sign "CC" which is defined in group G3 as 00. (this
-///          is by the article 33).
-/// 20-7F -> Group G0 as is - corresponds to the ASCII code
-/// 80-9F -> Characters that are in the G2 group in 60-7F
-///          (there are several blank characters here, that's OK)
-/// A0-FF -> Group G1 as is - non-English characters and symbols
-
-// NOTE: Same as `lib_ccx/ccx_decoder_708_encoding.c` file
+//! 256 BYTES IS ENOUGH FOR ALL THE SUPPORTED CHARACTERS IN
+//! EIA-708, SO INTERNALLY WE USE THIS TABLE (FOR CONVENIENCE)
+//!
+//! 00-1F -> Characters that are in the G2 group in 20-3F,
+//!          except for 06, which is used for the closed captions
+//!          sign "CC" which is defined in group G3 as 00. (this
+//!          is by the article 33).
+//! 20-7F -> Group G0 as is - corresponds to the ASCII code
+//! 80-9F -> Characters that are in the G2 group in 60-7F
+//!          (there are several blank characters here, that's OK)
+//! A0-FF -> Group G1 as is - non-English characters and symbols
+//!
+//! NOTE: Same as `lib_ccx/ccx_decoder_708_encoding.c` file
 
 #[no_mangle]
 pub extern "C" fn dtvcc_get_internal_from_G0(g0_char: u8) -> u8 {