-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #1599
[WIP] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #1599
Conversation
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 2ada36d...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
cd70187
to
c5dadaa
Compare
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5748042...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Check the result page for more info. |
c5dadaa
to
5748042
Compare
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1499
Work to be done in this PR:
ccxr_dtvcc_init()
in lib.rs and use this at all places wheredtvcc_init()
is being called. (Probably add a new struct field to lib_cc_decode likedtvcc_rust
and store Dtvcc there instead of using the dtvcc field)dtvcc_free()
dec_ctx
instead of creating a new oneAdditionally to fix mp4 code flow:-