[FEATURE] Create unit test for rust code #1615
Merged
+1,690
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshanGrover2004
force-pushed
the
create-unit-testing
branch
from
ab89a54 to
fea9774
Compare
|
The decoder moulde's unit test done @PunitLodha |
IshanGrover2004
changed the title
IshanGrover2004
force-pushed
the
create-unit-testing
branch
from
63388bb to
657cf3b
Compare
|
@IshanGrover2004 Can you also add a github CI check for running the unit tests |
|
Sure @PunitLodha |
This comment was marked as outdated.
This comment was marked as outdated.
IshanGrover2004
force-pushed
the
create-unit-testing
branch
2 times, most recently
from
2b2eb7a to
17355f2
Compare
|
@PunitLodha @cfsmp3 You can proceed for merging. I have added CI + all modules unit test cases |
PunitLodha
approved these changes
Aug 2, 2024
| decoder.is_header_parsed = true; | ||
| decoder.is_active = true; | ||
| decoder.report_enabled = true; | ||
| decoder.packet = vec![0xC2, 0x23, 0x45, 0x67, 0x00, 0x00]; |
There was a problem hiding this comment.
If you find some time, you can add comments here explaining what exactly the packet is here, the header the data
There was a problem hiding this comment.
Not possible tbh, bcs these are based on random values resulting of manipulation done in the functions & parameters passed as inputs. On based on that the resulted values are tested, I did not planned for any particular data.
Comment on lines
+267
to
+269
| assert_eq!(decoder.packet[0], 0x01); | ||
| assert_eq!(decoder.packet[1], 0x02); | ||
| assert_eq!(decoder.packet_length, 2); |
There was a problem hiding this comment.
Also, you could explain why we do these asserts. For example, why should decoder.packet[0] be equal to 0x01
Comment on lines
+1262
to
+1266
| decoder.windows[0].attribs.print_direction = | ||
| dtvcc_window_pd::DTVCC_WINDOW_PD_RIGHT_LEFT as i32; | ||
| decoder.process_cr(&mut encoder, &mut timing, no_rollup); | ||
| assert_eq!(decoder.windows[0].pen_row, 3); | ||
| assert_eq!(decoder.windows[0].pen_column, 10); |
There was a problem hiding this comment.
Same in this file, some comments would help
|
If you find time you can write the extra comments, otherwise it's fine |
Refactor the code and use Default where needed Implement `PartialEq` also
IshanGrover2004
force-pushed
the
create-unit-testing
branch
from
5bd3327 to
8ffab1d
Compare
|
@PunitLodha Added the CI & fixed the warnings as well |
PunitLodha
approved these changes
Aug 11, 2024
IshanGrover2004
added a commit
to IshanGrover2004/ccextractor-fork
that referenced
this pull request
Aug 23, 2024
* feat: Add new function to allocate any object to heap with zero allocated * feat: Add unit tests for `decoder/commands.rs` * docs: Mention about PR in changelogs * feat: Add unit tests for `decoder/windows.rs` Refactor the code and use Default where needed Implement `PartialEq` also * fix: Intialise tmp extern C values for easy mocking * feat: Add unit tests for `decoder/timing.rs` * feat: Add unit tests for `decoder/output.rs` * feat: Add unit tests for `decoder/mod.rs` * feat: Add unit tests for `decoder/tv_screen.rs` * feat: Add unit tests for `lib.rs` * fix: Failing test * feat: [WIP] Add unit tests for `decoder/service_decoder.rs` * feat: Add unit tests for `decoder/service_decoder.rs` * feat: Add unit tests for `hardsubx/imgops.rs` * feat: Add unit tests for `hardsubx/utility.rs` * fix: cargo clippy * fix: doctest for `lib_ccxr` module * feat: Add test `lib_ccxr/util/mod.rs` * feat: Add test `lib_ccxr/util/levenshtein.rs` * feat: Add test `lib_ccxr/util/bits.rs` * feat: Add test `lib_ccxr/time/units.rs` * chore: Change function name * fix: Failing of missing values `tlt_config` * ci: Run unit test cases in `lib_ccxr` module also * ci: Run clippy & fmt in `lib_ccxr` module also * chore(clippy): Fix clippy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Creating Unit test cases for rust modules(
decoder+hardsubx).Closes #911