Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading screen bug fixed, by giving permissions #370

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Shubham04Jha
Copy link
Contributor

@Shubham04Jha Shubham04Jha commented Nov 5, 2024

Description

Solved loading screen bug by giving necessary permissions.

Fixes #368

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@BrawlerXull
Copy link
Collaborator

LGTM!
Can you fix other Bugs related to Base Director too on the setting page where the base directory text is not being changed according to the setting applied by the user?
Also can you make the permissions logic more abstract?

@BrawlerXull
Copy link
Collaborator

LGTM 👏
@Pavel401 please review

@Pavel401
Copy link
Member

Pavel401 commented Nov 5, 2024

@BrawlerXull The CI flow is broken

@BrawlerXull
Copy link
Collaborator

BrawlerXull commented Nov 5, 2024

As per I guess it is because of GitHub deprecating versions v1 and v2 of the actions/upload-artifact action.
Well, I'll fix it!

@BrawlerXull BrawlerXull mentioned this pull request Nov 5, 2024
4 tasks
Copy link
Collaborator

@BrawlerXull BrawlerXull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tried to build the apk and it worked fine in my local device both the notification and storage service works fine!

@BrawlerXull BrawlerXull merged commit 3e0a0b7 into CCExtractor:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Changing Data Directory Not Working
3 participants