Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve tags add ux while adding task #399

Merged
merged 4 commits into from
Dec 19, 2024
Merged

feat: Improve tags add ux while adding task #399

merged 4 commits into from
Dec 19, 2024

Conversation

SGI-CAPP-AT2
Copy link
Contributor

@SGI-CAPP-AT2 SGI-CAPP-AT2 commented Dec 15, 2024 •
edited
Loading

Description

This PR improves the way tags can be added while adding tasks

  1. on inputing whitespace tag gets added
  2. if input has space in between, it adds the tags by splitting with whitespace
  3. also if tags are being repeated it'll delete the tag which was added previously and add again to show that it's added now

Fixes #398

After adding tags which has whitespace in between are not valid as per guidelines so after clicking on add task it shows an error snackbar.
It should be changed so that user will not have to delete tags and add differently without space.

Screenshots

FIX-IMPROVE-ADD-TASKS.mp4

Checklist

  • Code follows the established coding style guidelines
  • All tests are passing
  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes

@SGI-CAPP-AT2
feat: add tag to tags array immediately after input whitespace
71fa85e
@SGI-CAPP-AT2
feat: split tag input by whitespaces to avoid whitespaces in each tag
cfc6c9a
@SGI-CAPP-AT2
fix: remove tag if already exists in list and add again
9718a37 
Problem: while adding task a tag can be added multiple times

to fix this following bhavior will be followed:
   1. delete tag from list if already exists
   2. then add tag to list

So that the current tag can be added at last to show latest added tag
@SGI-CAPP-AT2
fix: removed dart:ffi added by recent commit
b2e8e0e
@SGI-CAPP-AT2
Copy link
Contributor Author

SGI-CAPP-AT2 commented Dec 15, 2024 •
edited
Loading

@BrawlerXull This PR is ready to review
If there is any idea to improve, please let me know

@SGI-CAPP-AT2 SGI-CAPP-AT2 changed the title Improve add tags feat: Improve tags add ux while adding task Dec 15, 2024
@SGI-CAPP-AT2
Copy link
Contributor Author

SGI-CAPP-AT2 commented Dec 16, 2024 •
edited
Loading

@BrawlerXull,
Yes but the tags which has spaces in between are not supported by taskwarrior
image
It shows above error
so to use tags like that user must use - or _
like Office-work or Pending-rentals

@BrawlerXull
Copy link
Collaborator

BrawlerXull commented Dec 16, 2024 •
edited
Loading

@BrawlerXull, Yes but the tags which has spaces in between are not supported by taskwarrior image It shows above error so to use tags like that user must use - or _ like Office-work or Pending-rentals

Yup! Will try it locally and let you know

@Pavel401 Pavel401 mentioned this pull request Dec 19, 2024
Open
1 task
Pavel401
Pavel401 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Pavel401 Pavel401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine. Merging this. Thanks, @SGI-CAPP-AT2

@Pavel401 Pavel401 merged commit 71614cd into CCExtractor:main Dec 19, 2024
2 checks passed
@linuxcaffe
Copy link

Excellent 👍

@SGI-CAPP-AT2 SGI-CAPP-AT2 deleted the improve-add-tags branch December 20, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavel401 Pavel401 Pavel401 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
TaskWarrior
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Improving ux for adding tags while adding task
4 participants
@SGI-CAPP-AT2 @BrawlerXull @linuxcaffe @Pavel401