-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Lap(Flag) of TimeInterval added #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
View file cannot contain any business logic, please keep it only for the UI.
@@ -52,7 +52,7 @@ class AlarmControlController extends GetxController { | |||
return latestAlarm; | |||
} | |||
|
|||
getNextAlarm() async { | |||
getAlarm() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this function renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, i replaced next unfortunately. i will solved all the problem make a fresh commit. Thanks
change unnecessary words
without conflicts
), | ||
endDrawer: buildEndDrawer(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using the buildEndDrawer to keep the drawers consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i used obx for EndDrawer in line no.89 to keep drawers consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a function called buildEndDrawer
in utils/end_drawer
which returns the endDrawer. We can reuse this function in order to make any change to the endDrawer reflect in all three pages.
), | ||
endDrawer: buildEndDrawer(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a function called buildEndDrawer
in utils/end_drawer
which returns the endDrawer. We can reuse this function in order to make any change to the endDrawer reflect in all three pages.
Description
New Lap(Flag) feature added,
When user start the stopwatch then reset button changes to flag button,
After pressing flag user get result of Timeinterval at the time of press.
When user pause the stopwatch then flag button converted to reset button,
and user if want then reset the stopwatch by pressing.
Fixes #406
Screenshots
WhatsApp.Video.2024-02-10.at.4.39.16.PM.mp4
Checklist
@MarkisDev, could you please review this PR