Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overflow Issue in Timer Pages for Smaller Mobile Devices #617

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

c-o-d-e-y-o-d-a
Copy link

Description

This PR addresses the overflow problem occurring on smaller mobile devices, such as the Nexus 5, specifically in the Timer pages. The UI elements have been adjusted to ensure proper responsiveness and alignment, providing a seamless experience across devices with smaller screen sizes.

Proposed Changes

  • Fixed layout constraints to prevent widget overflow.
  • Updated padding and margins for better scalability.
  • Verified compatibility with smaller screens like Nexus 5.

Fixes #(611)

Screenshots

On Nexus 5

gsoc.timer.issue.solvedd.mp4

On Samsung M21 2021 edition
UI on bigger devices

Checklist

  • [✔️] Tests have been added or updated to cover the changes
  • [✔️] Documentation has been updated to reflect the changes
  • [✔️] Code follows the established coding style guidelines
  • [✔️] All tests are passing

@ganidande905
Copy link
Contributor

ganidande905 commented Dec 19, 2024

Hey @c-o-d-e-y-o-d-a I've seen what you have done but the problem is, the height and width have been hardcoded in the timerview file
I think its better to just add mediaquery and then divide the width by 3 or set the width as screenwidth*0.2
Try doing it this way, I feel that is better
As I was working on another issue, I solved this issue too
I'll make a PR on this issue too, you can go through it and the maintainer could decide which ones good

@AryanSarafDev
Copy link
Collaborator

Nice Work @c-o-d-e-y-o-d-a . There are some conflicts in the pr. Can you resolve them? I will merge the pr after that.

@ganidande905
Copy link
Contributor

@AryanSarafDev merging my Previous Pr solved this issue too that's the reason the code is facing conflicts
So you can close this
Thank you

@AryanSarafDev
Copy link
Collaborator

@ganidande905 Sure. @c-o-d-e-y-o-d-a can you check in the latest build that is something missing from your pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants