Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue #638, save button initially over text now as a separate button below the add/update alarm form. #639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hardik17771
Copy link

@hardik17771 hardik17771 commented Jan 20, 2025

Description

This PR addresses the fix for issue #638 where the "Save" button on the AddOrUpdateAlarmView screen would overlap the content during scrolling. The changes ensure that the button remains fixed in its intended position, with only the screen content above it being scrollable.

Proposed Changes

  • Changed the body to Column widget with scrollable part inside the SingleChildScrollView with the help of Expanded widget and the save button outside the scrollable part.
  • Verified that the scrolling behavior works correctly without impacting the button's functionality or position.

Checklist

  • [☑️] Tests have been added or updated to cover the changes
  • [☑️] Documentation has been updated to reflect the changes
  • [☑️] Code follows the established coding style guidelines
  • [☑️] All tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant