Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline setup #83

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Pipeline setup #83

merged 7 commits into from
Jan 10, 2025

Conversation

swo
Copy link
Collaborator

@swo swo commented Dec 18, 2024

Note: The scripts here are not functional. There's even malformed Python code; this PR is intended to be fixed by later ones right away.

  • Read model names and score function names from config
  • Do computation for every combination of data set, model, forecast date, and score function
  • Separate into scripts
  • Use a Makefile

Base automatically changed from fy_config to main December 20, 2024 17:08
@Fuhan-Yang Fuhan-Yang marked this pull request as ready for review January 8, 2025 15:11
@Fuhan-Yang
Copy link
Contributor

This PR seperates one main.py to three files as preprocess.py, forecast.py, and eval.py. Each file receives the input from config.yaml, and is called by Makefile sequentially. To test the new pipeline, several errors need to fix:

  1. Error: "typeFloat64 is incompatible with expected type String" is returned in split_train_test. This happens when the uptake data is a single polars DataFrame (instead of a uptake data list).
  2. The NaN in training data prevents the fitting of LinearIncidenceUptakeModel, checks or methods (impute NA, or delete) are needed to ensure fitting can be run.

@Fuhan-Yang Fuhan-Yang requested a review from eschrom January 8, 2025 15:22
@swo swo requested a review from Fuhan-Yang January 10, 2025 15:38
@swo swo changed the title Suggestions: pipeline setup Pipeline setup Jan 10, 2025
@swo swo merged commit 5575cd3 into main Jan 10, 2025
1 of 2 checks passed
@swo swo deleted the fy_config_swo branch January 10, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants