Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

Portal 1387/count graph #82

Merged
merged 22 commits into from
Mar 18, 2024
Merged

Portal 1387/count graph #82

merged 22 commits into from
Mar 18, 2024

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Mar 18, 2024

Description

  • Adds <PieChart> component for use in displaying Submissions Statuses
  • Add data fetching methods to <Dashboard> (@ZacharyRizer)
  • Adds mock data to display in <PieChart> (@ZacharyRizer)

Notes

  • For the container "card" we are not using the cdc-react <Card> component at this time. However the style was mimicked and some css rules were copied from cdc-react to achieve a similar look.
  • For the legend we are using a custom styled <table>. We may need to add table headers to achieve 508 compliance. There may be an alternative way to code the markup such that it's more semantic.
  • Nivo - Doesn't appear to support "joining" two sections of the pie together. In the design the two failures were grouped into a single section of the pie. I don't believe we can support that currently.
  • Nivo - The patterns are matched as closely as possible. These are the available patterns: https://nivo.rocks/guides/patterns/. Not sure if these designs were final or we want to update to take advantage of what Nivo options are available.
  • Nivo - There are two options for PieChart display: <Pie> and <ResponsivePie>. ResponsivePie was not rendering correctly and spending 30-40mins I wasn't able to figure out the cause. More time could be spent to figure this out though.

Known issues

Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tbolt tbolt merged commit 8050af0 into main Mar 18, 2024
4 checks passed
@tbolt tbolt deleted the Portal-1387/Count-Graph branch March 18, 2024 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants