This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata-exchange-portal into Portal-1387/Count-Graph
Quality Gate passedIssues Measures |
ZacharyRizer
approved these changes
Mar 18, 2024
ian-sawyer
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<PieChart>
component for use in displaying Submissions Statuses<Dashboard>
(@ZacharyRizer)<PieChart>
(@ZacharyRizer)Notes
cdc-react
<Card>
component at this time. However the style was mimicked and some css rules were copied from cdc-react to achieve a similar look.<table>
. We may need to add table headers to achieve 508 compliance. There may be an alternative way to code the markup such that it's more semantic.<Pie>
and<ResponsivePie>
. ResponsivePie was not rendering correctly and spending 30-40mins I wasn't able to figure out the cause. More time could be spent to figure this out though.Known issues