Use session storage to persist filter and search #3114
+160
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
+ Coverage 87.02% 89.11% +2.08%
==========================================
Files 219 83 -136
Lines 13653 4244 -9409
Branches 703 720 +17
==========================================
- Hits 11882 3782 -8100
+ Misses 1762 442 -1320
- Partials 9 20 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gordonfarrell
requested review from
akasper,
angelathe,
austin-hall-skylight,
BobanL,
JNygaard-Skylight,
lina-roth,
mcmcgrath13 and
robertmitchellv
as code owners
mcmcgrath13
reviewed
Jan 9, 2025
| @@ -8,6 +8,7 @@ import { usePathname, useSearchParams, useRouter } from "next/navigation"; | |||
| import { range } from "../view-data/utils/utils"; | |||
| import classNames from "classnames"; | |||
| import Link from "next/link"; | |||
| import { saveToSessionStorage } from "./utils"; | |||
There was a problem hiding this comment.
could we add an e2e test that covers this functionality?
mcmcgrath13
reviewed
Jan 9, 2025
mcmcgrath13
reviewed
Jan 9, 2025
|
|
||
| return ( | ||
| <tr> | ||
| <td> | ||
| <Link href={`/view-data?id=${item.ecrId}`}> | ||
| <Link onClick={saveUrl} href={`/view-data?id=${item.ecrId}`}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Saves search param info into session storage and uses it to build the href for the link back to the eCR Library from the view page.
Related Issue
Fixes #3063
Acceptance Criteria
When a user has filters applied and navigates into a single eCR, the filters and/or search should persist on return