Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CSV, fixing linkChecker links #769

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Conversation

DavidMcClatchey
Copy link
Collaborator

@DavidMcClatchey DavidMcClatchey commented Jan 9, 2025

Related Issue or Background Info

Changes Proposed

  • Includes one CSV row that should upload successfully
  • Adds two HHS links to lycheeignore
  • Replaces embedded youtube link with a new embedded URL to the same thing
  • Removes the "staying-connected" page since this page had one of the failing linkChecker links and we had a story to remove the page altogether

Testing

  • Because we do not have device parity across all environments, including locally, the CSV fix is only testable after merging into the demo environment at the moment

@DavidMcClatchey DavidMcClatchey changed the title Updating CSV Updating CSV, fixing linkChecker links Jan 13, 2025
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your work on this!

Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the CSV fix locally and it lgtm. I know it's not quite the same as demo but the ID Now device should be in everyone's local since it's part of our sample data

@DavidMcClatchey DavidMcClatchey merged commit b7feb5c into main Jan 14, 2025
6 checks passed
@DavidMcClatchey DavidMcClatchey deleted the csv-template-fix branch January 14, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants