Bug fix: reminder service not using config (#8369)

* fix ID reminders config * Turn on reminder property for tests
CDCgov · Dec 26, 2024 · 2ccf672 · 2ccf672
1 parent c26128d
commit 2ccf672
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/backend/src/main/java/gov/cdc/usds/simplereport/service/ReminderService.java b/backend/src/main/java/gov/cdc/usds/simplereport/service/ReminderService.java
@@ -15,7 +15,7 @@
 import java.util.TimeZone;
 import lombok.extern.slf4j.Slf4j;
 import net.javacrumbs.shedlock.spring.annotation.SchedulerLock;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.scheduling.annotation.Scheduled;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -28,6 +28,9 @@ public class ReminderService {
   private final OrganizationQueueRepository _orgQueueRepo;
   private final EmailService _emailService;
 
+  @Value("${simple-report.id-verification-reminders.enabled}")
+  private boolean remindersEnabled;
+
   public ReminderService(OrganizationQueueRepository orgQueueRepo, EmailService emailService) {
     _orgQueueRepo = orgQueueRepo;
     _emailService = emailService;
@@ -42,9 +45,12 @@ public ReminderService(OrganizationQueueRepository orgQueueRepo, EmailService em
       name = "ReminderService_sendAccountReminderEmails",
       lockAtLeastFor = "PT30S",
       lockAtMostFor = "PT30M")
-  @ConditionalOnProperty("simple-report.id-verification-reminders.enabled")
   public void scheduledSendAccountReminderEmails() {
-    sendAccountReminderEmails();
+    if (remindersEnabled) {
+      sendAccountReminderEmails();
+    } else {
+      log.info("Skipping sending ID verification reminder emails");
+    }
   }
 
   /*

diff --git a/backend/src/test/java/gov/cdc/usds/simplereport/service/ReminderServiceTest.java b/backend/src/test/java/gov/cdc/usds/simplereport/service/ReminderServiceTest.java
@@ -24,8 +24,10 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.mock.mockito.MockBean;
 import org.springframework.jdbc.core.JdbcTemplate;
+import org.springframework.test.context.TestPropertySource;
 import org.springframework.transaction.annotation.Transactional;
 
+@TestPropertySource(properties = {"simple-report.id-verification-reminders.enabled=true"})
 class ReminderServiceTest extends BaseServiceTest<ReminderService> {
 
   @Autowired private JdbcTemplate _jdbc;