Migrating Okta users to the DB with no facilities (#8469)

* updating logic for no facilities * removing unnecessary exception catching
CDCgov · Feb 6, 2025 · 96618b3 · 96618b3
1 parent 965382b
commit 96618b3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/backend/src/main/java/gov/cdc/usds/simplereport/service/ApiUserService.java b/backend/src/main/java/gov/cdc/usds/simplereport/service/ApiUserService.java
@@ -875,10 +875,12 @@ private ApiUser setRolesAndFacilities(Optional<OrganizationRoles> orgRoles, ApiU
               .map(IdentifiedEntity::getInternalId)
               .collect(Collectors.toList());
       Set<Facility> facilitiesToGiveAccessTo =
-          getFacilitiesToGiveAccess(org, roles, new HashSet<>(facilitiesInternalIds));
+          facilitiesInternalIds.isEmpty()
+              ? new HashSet<>()
+              : getFacilitiesToGiveAccess(org, roles, new HashSet<>(facilitiesInternalIds));
       apiUser.setFacilities(facilitiesToGiveAccessTo);
       apiUser.setRoles(roles, org);
-    } catch (MisconfiguredUserException | PrivilegeUpdateFacilityAccessException e) {
+    } catch (MisconfiguredUserException e) {
       log.warn(
           "Could not migrate roles and facilities for user with id={}", apiUser.getInternalId());
     }