Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add equipment uid type to livd sync #6727

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Oct 13, 2023

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds equipment uid type to the sync / creation flow
  • Updates relevant models, GQL types, and tests to account for the new column

Testing

  • deployed on dev2. Ran the dry run sync and got the below output

Query

traces 
| where message has "equipmentUidType"

Result (matches expectations from the COVID LIVD spreadsheet > LOINC mapping tab)

Updating device UpdateDeviceType(internalId=4cdec84b-62f6-4e9f-8f2e-2789e0c61fa3, name=null, manufacturer=Acutis Diagnostics, model=LDT: SARS-CoV-2 Acutis Multiplex Assay, swabTypes=[8e07cba1-7a0f-42b7-ba36-df3bd1bf2e28], supportedDiseaseTestPerformed=[SupportedDiseaseTestPerformedInput(supportedDisease=0ad7c0d1-7677-456d-be76-d33e9b007165, testPerformedLoincCode=94533-7, equipmentUid=10190302015592, equipmentUidType=DII, testkitNameId=SARS-CoV-2 Acutis Multiplex Assay_Acutis Diagnostics, testOrderedLoincCode=94533-7), SupportedDiseaseTestPerformedInput(supportedDisease=0ad7c0d1-7677-456d-be76-d33e9b007165, testPerformedLoincCode=94533-7, equipmentUid=ABI QuantStudio 12K Flex_Thermo Fisher, equipmentUidType=MNI, testkitNameId=SARS-CoV-2 Acutis Multiplex Assay_Acutis Diagnostics, testOrderedLoincCode=94533-7)], testLength=0)

@fzhao99 fzhao99 force-pushed the bob/6641-add-equipment-uid-to-livd-sync branch 2 times, most recently from 96ef846 to e18b48d Compare October 13, 2023 20:23
@fzhao99 fzhao99 changed the title Bob/6641 add equipment uid to livd sync add equipment uid type to livd sync Oct 16, 2023
@fzhao99 fzhao99 temporarily deployed to dev2 October 16, 2023 15:20 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to dev2 October 16, 2023 15:30 — with GitHub Actions Inactive
@fzhao99 fzhao99 marked this pull request as ready for review October 16, 2023 19:38
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question. Code looks good overall!. I saw updates to the graphql types. Do we need to test the createDeviceType and updateDeviceType operations?

@fzhao99 fzhao99 marked this pull request as draft October 18, 2023 13:04
@fzhao99 fzhao99 force-pushed the bob/6641-add-equipment-uid-to-livd-sync branch from ab1ae5e to 270a7c1 Compare October 18, 2023 14:02
@fzhao99 fzhao99 temporarily deployed to dev2 October 18, 2023 14:07 — with GitHub Actions Inactive
@@ -35,8 +35,8 @@ type Facility {
isDeleted: Boolean
}

Copy link
Contributor Author

@fzhao99 fzhao99 Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter caught some whitespace changes here. should be a no-op outside the changes to the SupportedDisease objects

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@fzhao99 fzhao99 marked this pull request as ready for review October 18, 2023 15:22
@fzhao99 fzhao99 requested a review from mehansen October 18, 2023 15:22
@fzhao99
Copy link
Contributor Author

fzhao99 commented Oct 18, 2023

Left one question. Code looks good overall!. I saw updates to the graphql types. Do we need to test the createDeviceType and updateDeviceType operations?

@johanna-skylight redid the setup so the GQL objects should be untouched now! Lmk if you want to test the changes to the SupportedDisease objects though

Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and sync looks good!

Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes Bob 💯

@fzhao99 fzhao99 added this pull request to the merge queue Oct 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2023
@fzhao99 fzhao99 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit e3d085e Oct 18, 2023
@fzhao99 fzhao99 deleted the bob/6641-add-equipment-uid-to-livd-sync branch October 18, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants