-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add equipment uid type to livd sync #6727
Conversation
96ef846
to
e18b48d
Compare
backend/src/main/java/gov/cdc/usds/simplereport/service/DeviceTypeService.java
Fixed
Show fixed
Hide fixed
backend/src/main/java/gov/cdc/usds/simplereport/service/DeviceTypeService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question. Code looks good overall!. I saw updates to the graphql types. Do we need to test the createDeviceType
and updateDeviceType
operations?
ab1ae5e
to
270a7c1
Compare
@@ -35,8 +35,8 @@ type Facility { | |||
isDeleted: Boolean | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter caught some whitespace changes here. should be a no-op outside the changes to the SupportedDisease objects
Kudos, SonarCloud Quality Gate passed! |
@johanna-skylight redid the setup so the GQL objects should be untouched now! Lmk if you want to test the changes to the SupportedDisease objects though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and sync looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes Bob 💯
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Testing
Query
Result (matches expectations from the COVID LIVD spreadsheet > LOINC mapping tab)