Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Johanna/6295 uploader doc updates rsv #6768

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Johanna/6295 uploader doc updates rsv #6768

merged 3 commits into from
Oct 19, 2023

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Oct 18, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Update the text in the information banner of the bulk upload page.

Additional Information

  • The document with the new guide was already updated.
  • I am not fixing the the sonar cloud smell about putting a {/* */} between elements that don't have space because I don't think that helps with code maintainability at all.

Testing

Verify that the information banner in the bulk upload page has been updated.

Screenshots / Demos

Screenshot 2023-10-18 at 1 15 13 PM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanna-skylight
Copy link
Contributor Author

@lauraykerr can you review the screenshot of the banner updates when you have a chance?

@johanna-skylight johanna-skylight marked this pull request as ready for review October 18, 2023 17:16
@lauraykerr
Copy link
Contributor

@lauraykerr can you review the screenshot of the banner updates when you have a chance?

LGTM, thanks!

emyl3
emyl3 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BobanL
BobanL approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johanna-skylight johanna-skylight added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 11b046d Oct 19, 2023
@johanna-skylight johanna-skylight deleted the johanna/6295_uploader_doc_updates_rsv branch October 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@BobanL BobanL BobanL approved these changes

@fzhao99 fzhao99 Awaiting requested review from fzhao99

@jayna-SkylightDigital jayna-SkylightDigital Awaiting requested review from jayna-SkylightDigital

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation changes for supporting RSV in bulk result upload
4 participants
@johanna-skylight @lauraykerr @BobanL @emyl3