Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.graphql-java:graphql-java-extended-scalars in /backend #7793

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Jun 11, 2024

BACKEND PULL REQUEST

Related Issue

Additional Information

  • Had to reopen to get the checks on the PR to run

Testing

  • Deployed on dev2

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -43,7 +43,7 @@ dependencies {
// graphql-java-extended-validation schema directives
implementation 'com.graphql-java:graphql-java-extended-validation:21.0'
// graphql-java-extended-scalars
implementation 'com.graphql-java:graphql-java-extended-scalars:20.0'
implementation 'com.graphql-java:graphql-java-extended-scalars:22.0'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I don't think we are actually using this...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it is a dependency of com.graphql-java:graphql-java-extended-validation:21.0 which we do use 😅

@emyl3 emyl3 marked this pull request as ready for review June 11, 2024 19:17
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on dev 2!

Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested hitting several different flows hitting a variety of different backend endpoints and everything was working as expected on dev2 -- lgtm

@fzhao99 fzhao99 added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 9aaa153 Jun 14, 2024
41 checks passed
@fzhao99 fzhao99 deleted the elisa/dependabot/gradle/backend/com.graphql-java-graphql-java-extended-scalars-22.0 branch June 14, 2024 17:10
shanice-skylight pushed a commit that referenced this pull request Jun 26, 2024
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants