Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup storybook files #7805

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Cleanup storybook files #7805

merged 1 commit into from
Jun 14, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Jun 13, 2024

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Move storybook .stories.tsx files in the same directory as their component file equivalent
  • Fix the frontend/src/patientApp/selfRegistration/SelfRegistration.stories.tsx file
  • Remove the frontend/src/stories/Tag.stories.tsx file

Additional Information

  • N/A

Testing

  • Check storybook locally or here

Screenshots / Demos

Story organization

BEFORE
Screenshot 2024-06-13 at 12 19 12

** AFTER**
Screenshot 2024-06-13 at 12 16 56

@emyl3 emyl3 force-pushed the elisa/cleanup-storybook branch from 0955d40 to b81b292 Compare June 13, 2024 16:55
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@emyl3 emyl3 marked this pull request as ready for review June 13, 2024 17:21
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this Elisa!

Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@emyl3 emyl3 added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit db562d2 Jun 14, 2024
35 of 37 checks passed
@emyl3 emyl3 deleted the elisa/cleanup-storybook branch June 14, 2024 17:37
shanice-skylight pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants