-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkboxes disabled bug #7831
Conversation
44be9de
to
3f4499f
Compare
Quality Gate passedIssues Measures |
import Checkboxes, { generateCheckboxColumns } from "./Checkboxes"; | ||
|
||
describe("Checkboxes", () => { | ||
it("generateCheckboxColumns - creates array of arrays, subarrays of length n, when passed an array of items and n", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing that I introduced this bug refactoring the checkboxes, so thanks for fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Dev3 and working for me -- thanks for your work on this!
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
disabled
attribute not being properly set on and passed to the<input>
for the<Checkboxes>
componentAdditional Information
Testing
<Checkboxes>
component renders thedisabled
state correctly[email protected]
)Screenshots / Demos
AFTER FIX