Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkboxes disabled bug #7831

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix checkboxes disabled bug #7831

merged 1 commit into from
Jun 25, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Jun 20, 2024

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Fix disabled attribute not being properly set on and passed to the <input> for the <Checkboxes> component

Additional Information

  • N/A

Testing

  • Deployed on dev3
  • Ensure that any where we use the <Checkboxes> component renders the disabled state correctly
    • e.g. search a deleted user in the Support Admin -> Manage users feature (ex. [email protected])

Screenshots / Demos

AFTER FIX
Screenshot 2024-06-20 at 17 00 07

Copy link

import Checkboxes, { generateCheckboxColumns } from "./Checkboxes";

describe("Checkboxes", () => {
it("generateCheckboxColumns - creates array of arrays, subarrays of length n, when passed an array of items and n", () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ already existing test in the previous test file

@emyl3 emyl3 marked this pull request as ready for review June 20, 2024 22:08
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing that I introduced this bug refactoring the checkboxes, so thanks for fixing this!

Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Dev3 and working for me -- thanks for your work on this!

@emyl3 emyl3 added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 16eff5e Jun 25, 2024
43 checks passed
@emyl3 emyl3 deleted the elisa/7705-facility-select-bug branch June 25, 2024 18:24
shanice-skylight pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Facility select not disabled for deleted or admin user
3 participants