Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate failed Sonarqube builds #7853

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

shanice-skylight
Copy link
Collaborator

@shanice-skylight shanice-skylight commented Jun 27, 2024

DEVOPS PULL REQUEST

Related Issue

  • See Issue for this PR here
  • Sonarcube seems to be intermittently failing to build in CI jobs. See examples here and here

Changes Proposed

  • Added the sonar.java.binaries property and provided the value backend/build/classes/java/main which is the full path to the java classes
  • modified the ./gradlew sonarqube command to ./gradlew sonar due to sonarqube command being deprecated

Testing

  • See successful Github Action for sonar step to verify no longer failing
  • A smoke test of basic functionality should be accomplished before merging.
  • This PR has been verified on dev2

@shanice-skylight shanice-skylight linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link

Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

for future PR's if you wouldn't mind tagging reviewers, it'll show up in our GitHub notifications that the PR is ready for review. Went ahead and did that for this one.

Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for fixing

@shanice-skylight shanice-skylight added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 60980e9 Jun 28, 2024
40 checks passed
@shanice-skylight shanice-skylight deleted the shanice/sonar-revised branch June 28, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate failed Sonarqube builds
4 participants