-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
break out okta endpoint from health check #7891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple questions and nit comments but overall looks good! fun to see how you could set a custom status code
backend/src/main/java/gov/cdc/usds/simplereport/idp/repository/LiveOktaRepository.java
Show resolved
Hide resolved
Co-authored-by: Merethe Hansen <[email protected]>
backend/src/main/java/gov/cdc/usds/simplereport/api/heathcheck/OktaHealthIndicator.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
show-components: always | ||
status: | ||
http-mapping: | ||
okta_degraded: 204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pedantic nerd inside me debates the correctness of returning a 204/NO CONTENT. That's not to say that there is an existing 2xx status code that would be correct. But I'd almost be tempted to use a 2xx that doesn't have an existing status (like 299 for example).
At the end of the day I don't think it matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks Bob!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks Bob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😸
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
Testing
I've deployed this test branch that hardcodes a "down" status from the Okta check. Double check that the frontend status display looks ok and that the health check in Azure looks ok
Can also pull the value down locally and hard code return values for
getApplicationStatusForHealthCheck
in the demo okta repository to observe changes on the backend API return on port 8080 or on the frontend status page