Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shanice/logic alert integration #7979

Closed
wants to merge 21 commits into from

Conversation

shanice-skylight
Copy link
Collaborator

BACKEND PULL REQUEST

Related Issue

  • Why is this being done? Link to issue, or a few sentences describing why this PR exists

Changes Proposed

  • Detailed explanation of what this PR should do

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • How should reviewers verify this PR?

DATABASE PULL REQUEST

Related Issue

  • Why is this being done? Link to issue, or a few sentences describing why this PR exists

Changes Proposed

  • Detailed explanation of what this PR should do

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • How should reviewers verify this PR?

DEVOPS PULL REQUEST

Related Issue

  • Why is this being done? Link to issue, or a few sentences describing why this PR exists

Changes Proposed

  • Detailed explanation of what this PR should do

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • How should reviewers verify this PR?

FRONTEND PULL REQUEST

Related Issue

  • Why is this being done? Link to issue, or a few sentences describing why this PR exists

Changes Proposed

  • Detailed explanation of what this PR should do

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • How should reviewers verify this PR?

Screenshots / Demos

  • For large changes, please pair with a designer to ensure changes are as intended


module "logic_app_workflow" {
source = "../services/alerts/alert_app"
azure_alert_slack_webhook = ""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alismx I'm still not sure what to add as the value here in order to pull in the value of the Github secret named AZURE_ALERT_SLACK_WEBHOOK

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if instead of passing it in like this, you put this secret in the Azure vault and pull it via a terraform data object and use it that way? Like how we do here.

Once you have it, it seems like we might be able to use it like this.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants