Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Empty Syphilis Symptoms View #8051

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Fix Empty Syphilis Symptoms View #8051

merged 3 commits into from
Aug 22, 2024

Conversation

bobbywells52
Copy link
Collaborator

@bobbywells52 bobbywells52 commented Aug 21, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Create anAllSymptoms type system and update the symptomsStringToArray function to return a type of AllSymptomsName[] instead of just a RespiratorySymptomName[].

  • Create an allSymptomsMap for symptomsStringToArray to utilize instead of only referencing against the respiratorySymptomsMap.

Testing

  1. Conduct a postive test with the syphilis device in dev6
  2. Verify that syphilis symptoms are being displayed in the result view for the test

Screenshots / Demos

Screenshot 2024-08-21 at 1 58 43 PM

@bobbywells52 bobbywells52 changed the title Fix Symptoms View Fix Empty Syphilis Symptoms View Aug 21, 2024
@bobbywells52 bobbywells52 requested review from fzhao99 and emyl3 August 21, 2024 21:24
@bobbywells52 bobbywells52 marked this pull request as ready for review August 21, 2024 21:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fzhao99
fzhao99 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

emyl3
emyl3 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice work!

@bobbywells52 bobbywells52 added this pull request to the merge queue Aug 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 22, 2024
@bobbywells52
Fix Empty Syphilis Symptoms View (#8051)
35969b9 
* add more generic symptom typing and update function contracts

* add syphilis symptom specific test

* programatically generate allSymptomsMap
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2024
@bobbywells52 bobbywells52 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit a352b9e Aug 22, 2024
36 checks passed
@bobbywells52 bobbywells52 deleted the bobby/7901 branch August 22, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@fzhao99 fzhao99 fzhao99 approved these changes

@mpbrown mpbrown Awaiting requested review from mpbrown

@DanielSass DanielSass Awaiting requested review from DanielSass

@mehansen mehansen Awaiting requested review from mehansen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show syphilis symptoms in result view
3 participants
@bobbywells52 @emyl3 @fzhao99