Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original test event id for FHIR bundle corrections #8207

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Oct 17, 2024

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • When processing corrections, the FHIR converter now sets the diagnostic report id as the prior corrected test event id.

Additional Information

Testing

  • For local testing, your app backend should already default to printing out the FHIR bundle in the backend logs via the NoOpFHIRReportingService.
  • Submit a test event and use search in your logs to find "DiagnosticReport","id":. The UUID after this is the test event id. Now go to results page and start a correction for that same result. Make whatever changes you'd like on the correction and then submit it. Now check your logs for the latest case of "DiagnosticReport","id": which should contain the same test event id as the original.

Copy link

@mpbrown mpbrown marked this pull request as ready for review October 17, 2024 16:29
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it worked as expected!

@mpbrown mpbrown added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit b1154f9 Oct 22, 2024
32 checks passed
@mpbrown mpbrown deleted the mike/8084-fhir-original-uuid-corrections branch October 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference UUID from the originally created test event when generating FHIR bundle for corrections
3 participants