Bumps azure/login from 1 to 2.2.0 #8324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanice-skylight
changed the title
shanice-skylight
requested review from
DanielSass,
a team,
emyl3 and
mpbrown
and removed request for
a team
emyl3
reviewed
Dec 3, 2024
.github/workflows/slotSwapStgAPI.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| ARM_TENANT_ID: ${{ secrets.TERRAFORM_ARM_TENANT_ID }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: azure/login@v2 | |||
| - uses: azure/login@v2.2.0 | |||
There was a problem hiding this comment.
Question for my own understanding... Is there a reason we want to specify the minor version in this change? It looks like v2 tag without a minor version specified points to v2.2.0 🤔
There was a problem hiding this comment.
I didn't realize that v2 tag already pointed to 2.2.0. I'll remove the minor version so they are all consistent.
emyl3
reviewed
Dec 3, 2024
shanice-skylight
dismissed stale reviews from mpbrown and DavidMcClatchey
via
997ad2f
|
Waiting for cert renewal to be complete, then will move forward with merge |
|
rin-skylight
approved these changes
Dec 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shanice-skylight
removed this pull request from the merge queue due to a manual request
|
Re-ran backend test after it was removed from the merge queue and the test passed, so re-adding it to the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
Additional Information
dev2to tet it.Testing