Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CSV Template Name #8400

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Updating CSV Template Name #8400

merged 1 commit into from
Jan 15, 2025

Conversation

DavidMcClatchey
Copy link
Collaborator

@DavidMcClatchey DavidMcClatchey commented Jan 15, 2025 •
edited
Loading

Please DO NOT merge until we figure out what's going on with the static site here

Related Issue

Changes Proposed

Testing

  • This builds and runs locally, but it will need to be tested in the demo environment once it's deployed

emyl3
emyl3 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DavidMcClatchey
Copy link
Collaborator Author

Merging since both of these URLs currently work for downloading the new CSV:

https://demo.simplereport.gov/assets/resources/test_results_example_10-31-2023.csv
https://simplereport.gov/assets/resources/test_results_example_10-31-2023.csv

@DavidMcClatchey DavidMcClatchey added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@DavidMcClatchey DavidMcClatchey added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 4bedc2e Jan 15, 2025
38 checks passed
@DavidMcClatchey DavidMcClatchey deleted the csv-name-change branch January 15, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen mehansen approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass

@mpbrown mpbrown Awaiting requested review from mpbrown

@bobbywells52 bobbywells52 Awaiting requested review from bobbywells52

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidMcClatchey @mehansen @emyl3