Fix how we load csv files #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahouseholder
added
bug
ahouseholder
requested review from
cgyarbrough,
sei-vsarvepalli and
j---
as code owners
|
I intentionally bypassed the approval process on this one since it was a bug that only surfaced after #465 was merged and the linkchecker workflow failed when manually run. With this PR, the linkchecker workflow ran automatically and succeeded on this branch before merging, so I'm confident that the problem was resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in #465 then manually running the link checker uncovered a bug in how we had been loading the CSV files in a few places. This PR fixes that.