Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topo sort to csv analyzer and policy generator #473

Merged

Conversation

ahouseholder
Copy link
Contributor

@ahouseholder ahouseholder commented Feb 15, 2024

This PR

  • adds some topological sort checks to the csv analyzer and policy generator scripts.
  • reorders the report public and report credibility decision points to match expected directionality of values

These features were added after I noticed that report public and report credibility were improperly ordered according to the policy generator assumption that decision points are ordered from lowest-to-highest along a dimension that correlates to "likely to act".

@ahouseholder ahouseholder added enhancement New feature or request python Pull requests that update Python code labels Feb 15, 2024
@ahouseholder ahouseholder added this to the SSVC 202403 milestone Feb 15, 2024
@ahouseholder ahouseholder self-assigned this Feb 15, 2024
@ahouseholder ahouseholder changed the title Add topo sort to csv analyazer and policy generator Add topo sort to csv analyzer and policy generator Feb 15, 2024
Copy link
Contributor

@cgyarbrough cgyarbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not a coder, this seems to be almost an administrative change. The concept and my uninformed view of the code seems to be ok, but I'll defer to either Vijay or Jono to approve the changes.

@ahouseholder ahouseholder merged commit eecfa08 into main Feb 20, 2024
4 checks passed
@ahouseholder ahouseholder deleted the add_topo_sort_to_csv_analyazer_and_policy_generator branch February 20, 2024 18:57
@ahouseholder ahouseholder modified the milestones: 2024.3, 1Q24 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants