-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part A, Homework 2 #48
Open
nikita886
wants to merge
1
commit into
CFBSD-Summer2020:master
Choose a base branch
from
nikita886:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
.Rproj.user | ||
.Rhistory | ||
.RData | ||
.Ruserdata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
Version: 1.0 | ||
|
||
RestoreWorkspace: Default | ||
SaveWorkspace: Default | ||
AlwaysSaveHistory: Default | ||
|
||
EnableCodeIndexing: Yes | ||
UseSpacesForTab: Yes | ||
NumSpacesForTab: 2 | ||
Encoding: UTF-8 | ||
|
||
RnwWeave: Sweave | ||
LaTeX: pdfLaTeX |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,87 +1,100 @@ | ||
--- | ||
title: "What went wrong?" | ||
author: "Robert Gruener" | ||
date due: "7/13/2020" | ||
output: github_document | ||
--- | ||
|
||
```{r setup, include=TRUE} | ||
knitr::opts_chunk$set(echo = TRUE, error = TRUE) | ||
``` | ||
|
||
## HW02 Part A | ||
|
||
In this document, I will add some examples of some coding mistakes, it is up to you to figure out why the graphs are messing up. | ||
|
||
### First load packages | ||
|
||
It is always best to load the packages you need at the top of a script. It's another common coding formatting standard (like using the assignment operator instead of the equals sign). In this case, it helps people realize what they need to install for the script and gives an idea of what functions will be called. | ||
|
||
It is also best coding practice to only call the packages you use, so if you use a package but end up tossing the code you use for it, then make sure to remove loading it in the first place. For example, I could use `library("tidyverse")` but since this script will only be using ggplot2, I only load ggplot2. | ||
|
||
```{r load libraries} | ||
library("ggplot2") | ||
library("magrittr") #so I can do some piping | ||
``` | ||
|
||
|
||
### Graph Fail 1 | ||
|
||
What error is being thrown? How do you correct it? (hint, the error message tells you) | ||
|
||
```{r} | ||
data(mpg) #this is a dataset from the ggplot2 package | ||
|
||
mpg %>% | ||
ggplot(mapping = aes(x = city, y = hwy, color = "blue")) %>% | ||
geom_point() | ||
|
||
``` | ||
|
||
### Graph Fail 2 | ||
Why aren't the points blue? It is making me blue that the points in the graph aren't blue :`( | ||
```{r} | ||
ggplot(data = mpg) + | ||
geom_point(mapping = aes(x = displ, y = hwy, color = "blue")) | ||
|
||
``` | ||
|
||
|
||
|
||
### Graph Fail 3 | ||
Two mistakes in this graph. First, I wanted to make the the points slightly bolder, but changing the alpha to 2 does nothing. What does alpha do and what does setting it to 2 do? What could be done instead if I want the points slightly bigger? | ||
|
||
Second, I wanted to move the legend on top of the graph since there aren't any points there, putting it at approximately the point/ordered pair (5, 40). How do you actually do this? Also, how do you remove the legend title ("class")? Finally, how would you remove the plot legend completely? | ||
```{r} | ||
mpg %>% | ||
ggplot() + | ||
geom_point(mapping = aes(x = displ, y = hwy, color = class), alpha = 2) + | ||
theme(legend.direction = "horizontal") + | ||
theme(legend.position = c(5, 40)) | ||
|
||
``` | ||
|
||
### Graph Fail 4 | ||
I wanted just one smoothing line. Just one line, to show the general relationship here. But that's not happening. Instead I'm getting 3 lines, why and fix it please? | ||
|
||
```{r} | ||
mpg %>% | ||
ggplot(mapping = aes(x = displ, y = hwy, color = drv)) + | ||
geom_point() + | ||
geom_smooth(se = F) #se = F makes it so it won't show the error in the line of fit | ||
``` | ||
|
||
### Graph Fail 5 | ||
I got tired of the points, so I went to boxplots instead. However, I wanted the boxes to be all one color, but setting the color aesthetic just changed the outline? How can I make the box one color, not just the outline? | ||
|
||
Also, the x-axis labels were overlaping, so I rotated them. But now they overlap the bottom of the graph. How can I fix this so axis labels aren't on the graph? | ||
|
||
|
||
```{r} | ||
ggplot(data = mpg, mapping = aes(x = manufacturer, y = cty, color = manufacturer)) + | ||
geom_boxplot() + | ||
theme(axis.text.x = element_text(angle = 45)) | ||
``` | ||
|
||
|
||
|
||
--- | ||
title: "What went wrong?" | ||
author: "Robert Gruener" | ||
date due: "7/13/2020" | ||
output: github_document | ||
|
||
editor: Nikita Mehta | ||
--- | ||
|
||
```{r setup, include=TRUE} | ||
knitr::opts_chunk$set(echo = TRUE, error = TRUE) | ||
``` | ||
|
||
## HW02 Part A | ||
|
||
In this document, I will add some examples of some coding mistakes, it is up to you to figure out why the graphs are messing up. | ||
|
||
### First load packages | ||
|
||
It is always best to load the packages you need at the top of a script. It's another common coding formatting standard (like using the assignment operator instead of the equals sign). In this case, it helps people realize what they need to install for the script and gives an idea of what functions will be called. | ||
|
||
It is also best coding practice to only call the packages you use, so if you use a package but end up tossing the code you use for it, then make sure to remove loading it in the first place. For example, I could use `library("tidyverse")` but since this script will only be using ggplot2, I only load ggplot2. | ||
|
||
```{r load libraries} | ||
library("ggplot2") | ||
library("magrittr") #so I can do some piping | ||
``` | ||
|
||
|
||
### Graph Fail 1 | ||
|
||
What error is being thrown? How do you correct it? (hint, the error message tells you) | ||
|
||
Nikita - The first error is that we used %>% instead of +? | ||
|
||
```{r} | ||
data(mpg) #this is a dataset from the ggplot2 package | ||
|
||
mpg %>% | ||
ggplot(mapping = aes(x = city, y = hwy, color = "blue")) %>% | ||
geom_point() | ||
|
||
``` | ||
|
||
### Graph Fail 2 | ||
Why aren't the points blue? It is making me blue that the points in the graph aren't blue :`( | ||
|
||
Nikita - I fixed the code! Essentially, the points weren't showing up as blue because the color argument was inside the 'aes'. It should have been outside the aes! | ||
|
||
```{r} | ||
ggplot(data = mpg) + | ||
geom_point(color= 'blue', mapping = aes(x = displ, y = hwy)) | ||
|
||
``` | ||
|
||
|
||
### Graph Fail 3 | ||
Two mistakes in this graph. First, I wanted to make the the points slightly bolder, but changing the alpha to 2 does nothing. What does alpha do and what does setting it to 2 do? What could be done instead if I want the points slightly bigger? | ||
|
||
Second, I wanted to move the legend on top of the graph since there aren't any points there, putting it at approximately the point/ordered pair (5, 40). How do you actually do this? Also, how do you remove the legend title ("class")? Finally, how would you remove the plot legend completely? | ||
|
||
Nikita - Alpha changes the transparency of the points, and setting it to 2 makes it so that the graph won't show up at all since opacity is on a 0-1 scale. If you want the points to be bigger, you should add a size argument. Using the function, theme, will allow you to change the position. Instead of 5, 40, you should change it to "top". That will move the legened to the top. If you want to remove the legend title, say theme(legend.title)=element_blank()). If you want to remove the legend entirely, say theme(legend.position='none'). | ||
|
||
```{r} | ||
mpg %>% | ||
ggplot() + | ||
geom_point(mapping = aes(x = displ, y = hwy, color = class), alpha = 1) + | ||
theme(legend.direction = "horizontal") + | ||
theme(legend.position = c(5, 40)) | ||
|
||
``` | ||
|
||
### Graph Fail 4 | ||
I wanted just one smoothing line. Just one line, to show the general relationship here. But that's not happening. Instead I'm getting 3 lines, why and fix it please? | ||
|
||
Nikita -I have been trying to figure this out, but I am not sure. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added "geom_point(aes(color=drv))" - basically I tool the color out from the main ggplot and had it apply to only the geom_point |
||
```{r} | ||
mpg %>% | ||
ggplot(mapping = aes(x = displ, y = hwy, color = drv)) + | ||
geom_point() + | ||
geom_smooth(se = F) #se = F makes it so it won't show the error in the line of fit | ||
``` | ||
|
||
### Graph Fail 5 | ||
I got tired of the points, so I went to boxplots instead. However, I wanted the boxes to be all one color, but setting the color aesthetic just changed the outline? How can I make the box one color, not just the outline? | ||
|
||
Also, the x-axis labels were overlaping, so I rotated them. But now they overlap the bottom of the graph. How can I fix this so axis labels aren't on the graph? | ||
|
||
Nikita - Change the color by putting it in the geom_boxplot argument. You have to use the the "fill" and "color" arguments. To change the axis labels, we can use the argument 'angle'. This will rotate them so they won't be overlapping with the axis. | ||
|
||
|
||
```{r} | ||
ggplot(data = mpg, mapping = aes(x = manufacturer, y = cty, color = manufacturer)) + | ||
geom_boxplot() + | ||
theme(axis.text.x = element_text(angle = 45)) | ||
``` | ||
|
||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your responses are so clear! It's great that you put your name/response so clearly in the code. It made it really easy to follow your answers!