feat: Attempt to utilize external applications for rar extract support #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This succeeded with a valid .rar file and failed with an invalid .rar file (a .zip file with its extension changed to .rar)
7z appears to work fine for me, and is more likely to be installed from the listed requirements.
Only show the in-app failure notification when all available extract methods fail. This avoids the potential of 3 error notifications for each rar file that fails to extract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely a slightly better solution for
.rarsupport than #146. The main difference is that this first attempts to utilize the7zcommand, which has likely been installed by the user as part of the listed7-Zipdependency. It will also continue trying the other methods, instead of stopping at the first failure.This change attempts to extract
.rarfiles in this order:7zcommandunrarcommandbit7zmethod.On my system, the
7zcommand was able to extract the.rartest files I have without issue, but this support may depend on what version of7zusers install.