Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack to #43ead56380b, hocn and flushing velocity issue #1002

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Update Icepack to #43ead56380b, hocn and flushing velocity issue #1002

merged 1 commit into from
Dec 17, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Dec 17, 2024

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack to #43ead56380b, hocn and flushing velocity issue
  • Developer(s):
    davidclemenssewell, apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    All tests pass as expected, not bit-for-bit, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#749e0742c0323cafe1723974b9e5ea4a6cc31bbe
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Update Icepack to #43ead56380b, hocn and flushing velocity issue, not bfb.

See CICE-Consortium/Icepack#504

dabail10
dabail10 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@apcraig
Copy link
Contributor Author

apcraig commented Dec 17, 2024

Will merge after GHActions completes. Thanks.

@apcraig apcraig merged commit dcba500 into CICE-Consortium:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabail10 dabail10 dabail10 approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees

@eclare108213 eclare108213

@dabail10 dabail10

Labels
Icepack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10