Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use geopandas.plot() for Centroids.plot() #896

Merged
merged 15 commits into from
Jul 9, 2024

Merge remote-tracking branch 'origin/develop' into feature/refactor_c…

4ab1729
Select commit
Loading
Failed to load commit list.
Merged

Use geopandas.plot() for Centroids.plot() #896

Merge remote-tracking branch 'origin/develop' into feature/refactor_c…
4ab1729
Select commit
Loading
Failed to load commit list.
Jenkins - WCR / Pylint succeeded Jul 8, 2024 in 0s

5 new issues, 446 total

Total New Outstanding Fixed Trend
446 5 441 1 👎

Reference build: climada_branches » develop #1149

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 0 1 4

Annotations

Check warning on line 482 in climada/hazard/centroids/centr.py

See this annotation in the file changed.

@jenkins-wcr jenkins-wcr / Pylint

trailing-whitespace

LOW:
Trailing whitespace
Raw output
Used when there is whitespace between the end of a line and the newline.

Check warning on line 497 in climada/hazard/centroids/centr.py

See this annotation in the file changed.

@jenkins-wcr jenkins-wcr / Pylint

trailing-whitespace

LOW:
Trailing whitespace
Raw output
Used when there is whitespace between the end of a line and the newline.

Check warning on line 502 in climada/hazard/centroids/centr.py

See this annotation in the file changed.

@jenkins-wcr jenkins-wcr / Pylint

singleton-comparison

LOW:
Comparison 'axis == None' should be 'axis is None'
Raw output
Used when an expression is compared to singleton values like True, False orNone.

Check warning on line 504 in climada/hazard/centroids/centr.py

See this annotation in the file changed.

@jenkins-wcr jenkins-wcr / Pylint

unidiomatic-typecheck

LOW:
Using type() instead of isinstance() for a typecheck.
Raw output
The idiomatic way to perform an explicit typecheck in Python is to useisinstance(x, Y) rather than type(x) == Y, type(x) is Y. Though there areunusual situations where these give different results.

Check warning on line 503 in climada/hazard/centroids/centr.py

See this annotation in the file changed.

@jenkins-wcr jenkins-wcr / Pylint

unused-variable

NORMAL:
Unused variable 'fig'
Raw output
Used when a variable is defined but not used.