Warn about and discourage the use of pickle to save objects #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spjuhel
changed the title
|
🤩 Very good. Real cool link definition (transient format)[saving-with-pickle) |
You have to thank @peanutfun for this nice format! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Climada offers the possibility to use pickle to save most objects. Yet, this format is dependent on the python environment used when saving any object and thus offer very limited portability.
This is tied to SCRUM task 149 and User Story 148 (Improve saving conventions for Climada objects)
PR Author Checklist
develop)PR Reviewer Checklist