-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for Text-sentiment-classifier #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tedhtchang thanks. just a few comments below to resolve. let me know if anything is unclear or you need assistance resolving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates so far
@tedhtchang thanks for the updates. when running added 420 packages from 304 contributors and audited 1500 packages in 33.874s
found 1 low severity vulnerability
run `npm audit fix` to fix them, or `npm audit` for details in addition when running > rollup --config rollup.config.js
src/text-sentiment-classifier.ts → dist/src/max.sentimentclass.js, dist/src/max.sentimentclass.es.js...
created dist/src/max.sentimentclass.js, dist/src/max.sentimentclass.es.js in 4.4s
src/text-sentiment-classifier.ts → dist/src/max.sentimentclass.cjs.js...
(!) Missing exports
https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
src/server/sentimentanalysis.ts
io is not exported by node_modules/@tensorflow/tfjs-node/dist/index.js
4: var vocabUrl = 'https://s3.us-south.cloud-object-storage.appdomain.cloud/max-assets-prod/max-text-sentiment-classifier/tfjs/0.1.0/vocab.json';
5: var modelJsonUrl = 'https://s3.us-south.cloud-object-storage.appdomain.cloud/max-assets-prod/max-text-sentiment-classifier/tfjs/0.1.0/model.json';
6: tf.io.registerLoadRouter(tf.io.http);
^ |
Hi @vabarbosa Please review. Thanks!