fix(api): fix a couple of sonar cloud lint issues (#569)

COSCRAD · Mar 5, 2024 · 3a56466 · 3a56466
1 parent 2411a3b
commit 3a56466
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/apps/api/src/domain/models/audio-visual/audio-item/entities/audio-item.entity.ts b/apps/api/src/domain/models/audio-visual/audio-item/entities/audio-item.entity.ts
@@ -304,8 +304,6 @@ export class AudioItem extends Resource implements IRadioPublishableResource {
             availableCommandIds.push(`TRANSLATE_LINE_ITEM`);
 
         return availableCommandIds;
-
-        return availableCommandIds;
     }
 
     private isMIMETypeAllowed(mimeType: MIMEType): boolean {

diff --git a/apps/api/src/domain/models/song/song.entity.ts b/apps/api/src/domain/models/song/song.entity.ts
@@ -104,17 +104,13 @@ export class Song extends Resource {
     }
 
     protected validateComplexInvariants(): InternalError[] {
-        const allErrors: InternalError[] = [];
-
         const { title } = this;
 
         const titleValidationResult = title.validateComplexInvariants();
 
-        const titleValidationErrors = isInternalError(titleValidationResult)
-            ? [titleValidationResult]
-            : [];
+        const allErrors = isInternalError(titleValidationResult) ? [titleValidationResult] : [];
 
-        return allErrors.concat(titleValidationErrors);
+        return allErrors;
     }
 
     protected getExternalReferences(): AggregateCompositeIdentifier[] {